Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1277 Redesign note details #1278

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Jun 23, 2021

Fix #1277

image

Signed-off-by: Stefan Niedermann <[email protected]>
Signed-off-by: Stefan Niedermann <[email protected]>
@korelstar
Copy link
Member

I like it, but I'm unsure if "save" is the correct wording. Maybe "OK" is better?

According to the Material Design Guidelines, I would understand this dialog as confirmation dialog, which should have buttons Cancel and OK.
https://material.io/components/dialogs#confirmation-dialog

@stefan-niedermann
Copy link
Member Author

stefan-niedermann commented Jun 24, 2021

I am not yet sure how i want to implement it - either save implicitly, just like the notes itself, or explicitly using a button (as it is at the moment). By the way the favorite state is saved directly, regardless of the buttom you choose - it felt unnatural to only save it after pressing a button...

From various people i learned that the primary button should be a verb rather than just "ok", so the user is more aware of the actual action 🤷‍♂️ but that's just wording, still have some bigger issues / troubles to be solved 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign note details
2 participants